[CI/Build] Re-enable registry tests for 3 now-public model checkpoints#48370
Draft
guoriyue wants to merge 1 commit into
Draft
[CI/Build] Re-enable registry tests for 3 now-public model checkpoints#48370guoriyue wants to merge 1 commit into
guoriyue wants to merge 1 commit into
Conversation
Granite4VisionForConditionalGeneration, GlmOcrMTPModel and
Qwen3DSparkModel carry is_available_online=False, set while their
checkpoints were unpublished. All three repos are now public on the
Hub, their configs declare the registered architectures, and
test_can_initialize_large_subset passes for all three locally, so the
flags only disable coverage.
An audit of the remaining flagged entries found the rest must stay
flagged — not for availability, but because initialization genuinely
fails: DeepSeek-V4 asserts fp8_ds_mla requires an fp8 kv-cache (the
test uses auto), MiniMax-M3 OOMs a 32 GiB GPU even with dummy weights,
and Gemma4-Unified/Intern-S2 hit config errors ('sliding_attention' is
not in list). Those need their own fixes before unflagging.
Same defect class as the Cosmos3 fix in vllm-project#48211.
Assisted-by: Claude
Signed-off-by: Mingfei Guo <1800012773@pku.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Granite4VisionForConditionalGeneration,GlmOcrMTPModelandQwen3DSparkModelcarryis_available_online=Falseintests/models/registry.py, set while their checkpoints were unpublished. All three repos have since gone public, so the flags now only disable their CI coverage (initialization, and for Granite4-Vision the multimodal processing tests). Same class as #48211.Each entry was verified three ways before unflagging: the HF repo is public, its
config.jsondeclares the registered architecture, andtest_can_initialize_large_subsetpasses locally.An audit of the other flagged entries found they must stay flagged — not for availability, but because initialization genuinely fails today: DeepSeek-V4 asserts
fp8_ds_mlarequires an fp8 KV cache (the test usesauto), MiniMax-M3 OOMs a 32 GiB GPU even with dummy weights, and Gemma4-Unified/Intern-S2 hit config errors. Details in the commit message; those need their own fixes first.Test Plan
pytest tests/models/test_initialization.py -k "Granite4Vision or GlmOcrMTP or Qwen3DSpark"Test Result
On 1×RTX 5090: